RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 02:42:44 +00:00
Code Issues Activity Actions

HackStudio: Make a new ProjectBuilder object when opening a project

Browse source 
We couldn't compile a project after creating it, because the project
builder was still holding a reference to the previous freed project.

Fixes: #15715
This commit is contained in:
Karol Kosek 2022-12-22 12:58:10 +01:00 • committed by Andreas Kling
parent 98fa3736ed
commit b67762a7f3
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/DevTools/HackStudio/HackStudioWidget.cpp
View file

@ -185,7 +185,6 @@ ErrorOr<NonnullRefPtr<HackStudioWidget>> HackStudioWidget::create(DeprecatedStri
}; };
} }
widget->m_project_builder = make<ProjectBuilder>(*widget->m_terminal_wrapper, *widget->m_project);
widget->project().model().set_should_show_dotfiles(Config::read_bool("HackStudio"sv, "Global"sv, "ShowDotfiles"sv, false)); widget->project().model().set_should_show_dotfiles(Config::read_bool("HackStudio"sv, "Global"sv, "ShowDotfiles"sv, false));
return widget; return widget;
@ -252,6 +251,7 @@ void HackStudioWidget::open_project(DeprecatedString const& root_path)
} }
m_project = Project::open_with_root_path(root_path); m_project = Project::open_with_root_path(root_path);
VERIFY(m_project); VERIFY(m_project);
m_project_builder = make<ProjectBuilder>(*m_terminal_wrapper, *m_project);
if (m_project_tree_view) { if (m_project_tree_view) {
m_project_tree_view->set_model(m_project->model()); m_project_tree_view->set_model(m_project->model());
m_project_tree_view->update(); m_project_tree_view->update();