From b683e8ab77ce05085272239dcd177bfe1d76f4c6 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Thu, 10 Feb 2022 08:15:18 -0500 Subject: [PATCH] LibSQL: Return unimplemented errors from unimplemented MATCH expressions A bit friendlier than crashing the entire SQLService process. --- Userland/Libraries/LibSQL/AST/Expression.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibSQL/AST/Expression.cpp b/Userland/Libraries/LibSQL/AST/Expression.cpp index d9b3cc8696..2d48cfcadb 100644 --- a/Userland/Libraries/LibSQL/AST/Expression.cpp +++ b/Userland/Libraries/LibSQL/AST/Expression.cpp @@ -239,11 +239,12 @@ ResultOr MatchExpression::evaluate(ExecutionContext& context) const return Value(invert_expression() ? !result.success : result.success); } case MatchOperator::Glob: + return Result { SQLCommand::Unknown, SQLErrorCode::NotYetImplemented, "GLOB expression is not yet implemented"sv }; case MatchOperator::Match: + return Result { SQLCommand::Unknown, SQLErrorCode::NotYetImplemented, "MATCH expression is not yet implemented"sv }; default: VERIFY_NOT_REACHED(); } - return Value::null(); } }