RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 23:47:45 +00:00
Code Issues Activity Actions

LibWeb: Fix handling of max-content containing block for floating box

Browse source 
Fixes layout of page toolbar on Wikipedia.
This commit is contained in:
Andi Gallo 2023-08-13 02:23:29 +00:00 • committed by Alexander Kalenik
parent 97ba1ff1f7
commit b6f9f4c28c
5 changed files with 94 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

27
Tests/LibWeb/Layout/expected/block-and-inline/float-max-content-containing-block-flex-display.txt Normal file
View file

@ -0,0 +1,27 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x0 children: not-inline
Box <div.display_flex> at (8,8) content-size 23.609375x17.46875 floating flex-container(row) [FFC] children: not-inline
BlockContainer <div> at (8,8) content-size 23.609375x17.46875 flex-item [BFC] children: not-inline
BlockContainer <div> at (8,8) content-size 23.609375x17.46875 floating [BFC] children: not-inline
BlockContainer <span> at (8,8) content-size 14.265625x17.46875 floating [BFC] children: inline
line 0 width: 14.265625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [8,8 14.265625x17.46875]
"A"
TextNode <#text>
BlockContainer <span> at (22.265625,8) content-size 9.34375x17.46875 floating [BFC] children: inline
line 0 width: 9.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [22.265625,8 9.34375x17.46875]
"B"
TextNode <#text>
PaintableWithLines (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x0] overflow: [8,8 23.609375x17.46875]
PaintableBox (Box<DIV>.display_flex) [8,8 23.609375x17.46875]
PaintableWithLines (BlockContainer<DIV>) [8,8 23.609375x17.46875]
PaintableWithLines (BlockContainer<DIV>) [8,8 23.609375x17.46875]
PaintableWithLines (BlockContainer<SPAN>) [8,8 14.265625x17.46875]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<SPAN>) [22.265625,8 9.34375x17.46875]
TextPaintable (TextNode<#text>)

23
Tests/LibWeb/Layout/expected/block-and-inline/float-max-content-containing-block.txt Normal file
View file

@ -0,0 +1,23 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x0 children: not-inline
BlockContainer <div> at (8,8) content-size 23.609375x17.46875 floating [BFC] children: not-inline
BlockContainer <span> at (8,8) content-size 14.265625x17.46875 floating [BFC] children: inline
line 0 width: 14.265625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [8,8 14.265625x17.46875]
"A"
TextNode <#text>
BlockContainer <span> at (22.265625,8) content-size 9.34375x17.46875 floating [BFC] children: inline
line 0 width: 9.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [22.265625,8 9.34375x17.46875]
"B"
TextNode <#text>
PaintableWithLines (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x0] overflow: [8,8 23.609375x17.46875]
PaintableWithLines (BlockContainer<DIV>) [8,8 23.609375x17.46875]
PaintableWithLines (BlockContainer<SPAN>) [8,8 14.265625x17.46875]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<SPAN>) [22.265625,8 9.34375x17.46875]
TextPaintable (TextNode<#text>)

13
Tests/LibWeb/Layout/input/block-and-inline/float-max-content-containing-block-flex-display.html Normal file
View file

@ -0,0 +1,13 @@
<style>
.display_flex {
display: flex;
}
div {
float: left;
}
span {
float: left;
}
</style><div class="display_flex"><div><div><span>A</span><span>B</span></div></div></div>

9
Tests/LibWeb/Layout/input/block-and-inline/float-max-content-containing-block.html Normal file
View file

@ -0,0 +1,9 @@
<style>
div {
float: left;
}
span {
float: left;
}
</style><div><span>A</span><span>B</span></div>