From b7676cc4360a786b3b35f264366ecc516c051e59 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Sun, 27 Aug 2023 14:52:29 -0400 Subject: [PATCH] LibJS: Disable Temporal custom time zone test This test has been flaky for quite some time. Disable it for now, and revisit once we've caught up with the Temporal spec. --- .../builtins/Temporal/Now/Now.plainDateTimeISO.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/Now/Now.plainDateTimeISO.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/Now/Now.plainDateTimeISO.js index a9f49ff357..af133cee11 100644 --- a/Userland/Libraries/LibJS/Tests/builtins/Temporal/Now/Now.plainDateTimeISO.js +++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/Now/Now.plainDateTimeISO.js @@ -28,7 +28,10 @@ describe("correct behavior", () => { // and negative timezones and skip one if we jump the year. To ensure at least one is // tested we have the timeZoneTested which is only set to true if one of the tests passed. - test("custom time zone positive", () => { + // FIXME: The custom time zone tests are disabled due to being flaky. See: + // https://github.com/SerenityOS/serenity/issues/20806 + + test.skip("custom time zone (positive)", () => { const timeZone = { getOffsetNanosecondsFor() { return 86399999999999; @@ -48,7 +51,7 @@ describe("correct behavior", () => { timeZoneTested = true; }); - test("custom time zone negative", () => { + test.skip("custom time zone (negative)", () => { const timeZone = { getOffsetNanosecondsFor() { return -86399999999999; @@ -68,7 +71,9 @@ describe("correct behavior", () => { timeZoneTested = true; }); - expect(timeZoneTested).toBeTrue(); + test.skip("custom time zone test was executed", () => { + expect(timeZoneTested).toBeTrue(); + }); test("cannot have a time zone with more than a day", () => { [86400000000000, -86400000000000, 86400000000001, 86400000000002].forEach(offset => {