RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-22 14:55:07 +00:00
Code Issues Activity Actions

HackStudio: Replace InProcessWebView with OutOfProcessWebView

Browse source
This commit is contained in:
Linus Groh 2020-10-08 21:47:00 +01:00 • committed by Andreas Kling
parent f0ba536095
commit b797de3adf
2 changed files with 11 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

19
DevTools/HackStudio/Editor.cpp
View file

@ -47,7 +47,7 @@
#include <LibWeb/DOM/ElementFactory.h>
#include <LibWeb/DOM/Text.h>
#include <LibWeb/HTML/HTMLHeadElement.h>
#include <LibWeb/InProcessWebView.h>
#include <LibWeb/OutOfProcessWebView.h>
// #define EDITOR_DEBUG
@ -59,7 +59,7 @@ Editor::Editor()
m_documentation_tooltip_window = GUI::Window::construct();
m_documentation_tooltip_window->set_rect(0, 0, 500, 400);
m_documentation_tooltip_window->set_window_type(GUI::WindowType::Tooltip);
m_documentation_page_view = m_documentation_tooltip_window->set_main_widget<Web::InProcessWebView>();
m_documentation_page_view = m_documentation_tooltip_window->set_main_widget<Web::OutOfProcessWebView>();
m_autocomplete_box = make<AutoCompleteBox>(make_weak_ptr());
}
@ -182,13 +182,14 @@ void Editor::show_documentation_tooltip_if_available(const String& hovered_token
return;
}
auto html_text = man_document->render_to_html();
m_documentation_page_view->load_html(html_text, {});
if (auto* document = m_documentation_page_view->document()) {
const_cast<Web::HTML::HTMLElement*>(document->body())->set_attribute(Web::HTML::AttributeNames::style, "background-color: #dac7b5;");
}
StringBuilder html;
// FIXME: With the InProcessWebView we used to manipulate the document body directly,
// With OutOfProcessWebView this isn't possible (at the moment). The ideal solution
// is probably to tweak Markdown::Document::render_to_html() so we can inject styles
// into the rendered HTML easily.
html.append(man_document->render_to_html());
html.append("<style>body { background-color: #dac7b5; }</style>");
m_documentation_page_view->load_html(html.build(), {});
m_documentation_tooltip_window->move_to(screen_location.translated(4, 4));
m_documentation_tooltip_window->show();