RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:48:11 +00:00
Code Issues Activity Actions

LibWeb: Fix check for too many 'normal' values in font declaration

Browse source 
I had the values backwards, oops!
This commit is contained in:
Sam Atkins 2021-08-16 15:41:33 +01:00 • committed by Andreas Kling
parent b64b97ef88
commit b7aba70a28
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -2400,14 +2400,13 @@ RefPtr<StyleValue> Parser::parse_font_value(ParsingContext const& context, Vecto
font_families = maybe_font_families.release_nonnull();
break;
}
return nullptr;
}
// Since normal is the default value for all the properties that can have it, we don't have to actually
// set anything to normal here. It'll be set when we create the FontStyleValue below.
// We just need to make sure we were not given more normals than will fit.
int unset_value_count = (font_style ? 1 : 0) + (font_weight ? 1 : 0);
int unset_value_count = (font_style ? 0 : 1) + (font_weight ? 0 : 1);
if (unset_value_count < normal_count)
return nullptr;