1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 04:17:35 +00:00

AK: Fix crash during teardown of self-owning objects

We now null out smart pointers *before* calling unref on the pointee.
This ensures that the same smart pointer can't be used to acquire a new
reference to the pointee after its destruction has begun.

I ran into this when destroying a non-empty IntrusiveList of RefPtrs,
but the problem was more general so this fixes it for all of RefPtr,
NonnullRefPtr, OwnPtr and NonnullOwnPtr.
This commit is contained in:
Andreas Kling 2023-04-21 13:36:32 +02:00
parent 66bd7cdb28
commit b7e847e58b
10 changed files with 102 additions and 14 deletions

View file

@ -129,10 +129,8 @@ public:
private:
void clear()
{
if (!m_ptr)
return;
delete m_ptr;
m_ptr = nullptr;
auto* ptr = exchange(m_ptr, nullptr);
delete ptr;
}
T* m_ptr = nullptr;