RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:38:10 +00:00
Code Issues Activity Actions

Kernel: Include the current instruction pointer in profile samples

Browse source 
We were missing the innermost instruction pointer when sampling.
This makes the instruction-level profile info a lot cooler! :^)
This commit is contained in:
Andreas Kling 2020-04-11 20:39:27 +02:00
parent c106451daf
commit b7ff3b5ad1
4 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Thread.cpp
View file

@ -846,13 +846,13 @@ String Thread::backtrace_impl() const
return builder.to_string();
}
Vector<FlatPtr> Thread::raw_backtrace(FlatPtr ebp) const
Vector<FlatPtr> Thread::raw_backtrace(FlatPtr ebp, FlatPtr eip) const
{
InterruptDisabler disabler;
auto& process = const_cast<Process&>(this->process());
ProcessPagingScope paging_scope(process);
Vector<FlatPtr, Profiling::max_stack_frame_count> backtrace;
backtrace.append(ebp);
backtrace.append(eip);
for (FlatPtr* stack_ptr = (FlatPtr*)ebp; process.validate_read_from_kernel(VirtualAddress(stack_ptr), sizeof(FlatPtr) * 2) && MM.can_read_without_faulting(process, VirtualAddress(stack_ptr), sizeof(FlatPtr) * 2); stack_ptr = (FlatPtr*)*stack_ptr) {
FlatPtr retaddr = stack_ptr[1];
backtrace.append(retaddr);