RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:17:35 +00:00
Code Issues Activity Actions

LibJS: Make sure queued promise jobs have an execution context when run

Browse source
This commit is contained in:
Andreas Kling 2021-10-11 22:19:46 +02:00
parent 9aa720e83e
commit b819719860
1 changed files with 14 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibJS/Runtime/VM.cpp
View file

@ -549,7 +549,21 @@ void VM::run_queued_promise_jobs()
while (!m_promise_jobs.is_empty()) { while (!m_promise_jobs.is_empty()) {
auto* job = m_promise_jobs.take_first(); auto* job = m_promise_jobs.take_first();
dbgln_if(PROMISE_DEBUG, "Calling promise job function @ {}", job); dbgln_if(PROMISE_DEBUG, "Calling promise job function @ {}", job);
// NOTE: If the execution context stack is empty, we make and push a temporary context.
ExecutionContext execution_context(heap());
bool pushed_execution_context = false;
if (m_execution_context_stack.is_empty()) {
static FlyString promise_execution_context_name = "(promise execution context)";
execution_context.function_name = promise_execution_context_name;
push_execution_context(execution_context, job->global_object());
pushed_execution_context = true;
}
[[maybe_unused]] auto result = call(*job, js_undefined()); [[maybe_unused]] auto result = call(*job, js_undefined());
if (pushed_execution_context)
pop_execution_context();
} }
// Ensure no job has created a new exception, they must clean up after themselves. // Ensure no job has created a new exception, they must clean up after themselves.
VERIFY(!m_exception); VERIFY(!m_exception);