RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-29 14:25:07 +00:00
Code Issues Activity Actions

LibWeb: Only assign block container heights during BFC intrinsic sizing

Browse source 
Before this change, we were always assigning the calculated height to
each block container after laying it out in BFC.

This should really only happen during intrinsic sizing, since that is
how measurements are communicated to the client there.
This commit is contained in:
Andreas Kling 2024-01-29 15:30:42 +01:00
parent 6a662e0d43
commit b83e41c9b5
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View file

@ -549,9 +549,8 @@ void BlockFormattingContext::layout_inline_children(BlockContainer const& block_
used_width_px = min_width_px;
}
block_container_state.set_content_width(used_width_px);
}
if (!block_container_state.has_definite_height())
block_container_state.set_content_height(context.automatic_content_height());
}
}
CSSPixels BlockFormattingContext::compute_auto_height_for_block_level_element(Box const& box, AvailableSpace const& available_space)
@ -774,9 +773,8 @@ void BlockFormattingContext::layout_block_level_children(BlockContainer const& b
}
}
block_container_state.set_content_width(width);
}
if (!block_container_state.has_definite_height())
block_container_state.set_content_height(bottom_of_lowest_margin_box);
}
}
}