RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 00:17:46 +00:00
Code Issues Activity Actions

LibGfx: Disable line intersection stroking for 1px lines

Browse source 
1px lines are already connected, so this just makes things look worse
and is often painting in the wrong spot anyway.
This commit is contained in:
MacDue 2022-11-30 00:08:06 +00:00 • committed by Andreas Kling
parent 8dfe43273c
commit b8492006da
1 changed files with 9 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibGfx/AntiAliasingPainter.cpp
View file

@ -228,16 +228,15 @@ void AntiAliasingPainter::stroke_path(Path const& path, Color color, float thick
cursor = segment.point();
break;
case Segment::Type::LineTo:
if (!first_line.has_value())
first_line = FloatLine(cursor, segment.point());
draw_line(cursor, segment.point(), color, thickness);
if (previous_was_line) {
stroke_segment_intersection(cursor, segment.point(), last_line, color, thickness);
if (thickness > 1) {
if (!first_line.has_value())
first_line = FloatLine(cursor, segment.point());
if (previous_was_line)
stroke_segment_intersection(cursor, segment.point(), last_line, color, thickness);
last_line.set_a(cursor);
last_line.set_b(segment.point());
}
last_line.set_a(cursor);
last_line.set_b(segment.point());
cursor = segment.point();
break;
case Segment::Type::QuadraticBezierCurveTo: {
@ -264,8 +263,8 @@ void AntiAliasingPainter::stroke_path(Path const& path, Color color, float thick
previous_was_line = segment.type() == Segment::Type::LineTo;
}
// check if the figure was started and closed as line at the same position
if (previous_was_line && path.segments().size() >= 2 && path.segments().first().point() == cursor && (path.segments().first().type() == Segment::Type::LineTo || (path.segments().first().type() == Segment::Type::MoveTo && path.segments()[1].type() == Segment::Type::LineTo)))
// Check if the figure was started and closed as line at the same position.
if (thickness > 1 && previous_was_line && path.segments().size() >= 2 && path.segments().first().point() == cursor && (path.segments().first().type() == Segment::Type::LineTo || (path.segments().first().type() == Segment::Type::MoveTo && path.segments()[1].type() == Segment::Type::LineTo)))
stroke_segment_intersection(first_line.value().a(), first_line.value().b(), last_line, color, thickness);
}