mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 21:17:44 +00:00
LibJS: Make intrinsics getters return NonnullGCPtr
Some of these are allocated upon initialization of the intrinsics, and some lazily, but in neither case the getters actually return a nullptr. This saves us a whole bunch of pointer dereferences (as NonnullGCPtr has an `operator T&()`), and also has the interesting side effect of forcing us to explicitly use the FunctionObject& overload of call(), as passing a NonnullGCPtr is ambigous - it could implicitly be turned into a Value _or_ a FunctionObject& (so we have to dereference manually).
This commit is contained in:
parent
ed9e2366da
commit
b84f8fb55b
182 changed files with 564 additions and 567 deletions
|
@ -112,7 +112,7 @@ ThrowCompletionOr<Value> Reference::get_value(VM& vm) const
|
|||
}
|
||||
|
||||
// OPTIMIZATION: For various primitives we can avoid actually creating a new object for them.
|
||||
Object* base_obj = nullptr;
|
||||
GCPtr<Object> base_obj;
|
||||
if (m_base_value.is_string()) {
|
||||
auto string_value = TRY(m_base_value.as_string().get(vm, m_name));
|
||||
if (string_value.has_value())
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue