mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 02:17:35 +00:00
LibJS: Make intrinsics getters return NonnullGCPtr
Some of these are allocated upon initialization of the intrinsics, and some lazily, but in neither case the getters actually return a nullptr. This saves us a whole bunch of pointer dereferences (as NonnullGCPtr has an `operator T&()`), and also has the interesting side effect of forcing us to explicitly use the FunctionObject& overload of call(), as passing a NonnullGCPtr is ambigous - it could implicitly be turned into a Value _or_ a FunctionObject& (so we have to dereference manually).
This commit is contained in:
parent
ed9e2366da
commit
b84f8fb55b
182 changed files with 564 additions and 567 deletions
|
@ -549,10 +549,10 @@ void ConnectionFromClient::initialize_js_console(Badge<PageHost>)
|
|||
if (m_realm.ptr() == realm.ptr())
|
||||
return;
|
||||
|
||||
auto& console_object = *realm->intrinsics().console_object();
|
||||
auto console_object = realm->intrinsics().console_object();
|
||||
m_realm = realm;
|
||||
m_console_client = make<WebContentConsoleClient>(console_object.console(), *m_realm, *this);
|
||||
console_object.console().set_client(*m_console_client.ptr());
|
||||
m_console_client = make<WebContentConsoleClient>(console_object->console(), *m_realm, *this);
|
||||
console_object->console().set_client(*m_console_client.ptr());
|
||||
}
|
||||
|
||||
void ConnectionFromClient::js_console_input(DeprecatedString const& js_source)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue