diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp index 168685c06c..7cf0c30161 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp +++ b/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp @@ -1,6 +1,6 @@ /* * Copyright (c) 2021-2022, Idan Horowitz - * Copyright (c) 2021-2022, Linus Groh + * Copyright (c) 2021-2023, Linus Groh * Copyright (c) 2021, Luke Wilde * * SPDX-License-Identifier: BSD-2-Clause @@ -8,6 +8,7 @@ #include #include +#include #include #include #include @@ -155,17 +156,17 @@ ThrowCompletionOr get_option(VM& vm, Object const& options, PropertyKey c } // 13.4 ToTemporalOverflow ( options ), https://tc39.es/proposal-temporal/#sec-temporal-totemporaloverflow -ThrowCompletionOr to_temporal_overflow(VM& vm, Object const* options) +ThrowCompletionOr to_temporal_overflow(VM& vm, Object const* options) { // 1. If options is undefined, return "constrain". if (options == nullptr) - return "constrain"sv; + return TRY_OR_THROW_OOM(vm, String::from_utf8("constrain"sv)); // 2. Return ? GetOption(options, "overflow", "string", « "constrain", "reject" », "constrain"). auto option = TRY(get_option(vm, *options, vm.names.overflow, OptionType::String, { "constrain"sv, "reject"sv }, "constrain"sv)); VERIFY(option.is_string()); - return TRY(option.as_string().deprecated_string()); + return option.as_string().utf8_string(); } // 13.5 ToTemporalDisambiguation ( options ), https://tc39.es/proposal-temporal/#sec-temporal-totemporaldisambiguation diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.h b/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.h index 90eedf0062..3000fcec48 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.h +++ b/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.h @@ -1,6 +1,6 @@ /* * Copyright (c) 2021, Idan Horowitz - * Copyright (c) 2021-2022, Linus Groh + * Copyright (c) 2021-2023, Linus Groh * * SPDX-License-Identifier: BSD-2-Clause */ @@ -135,7 +135,7 @@ using TemporalUnitDefault = Variant>; ThrowCompletionOr> iterable_to_list_of_type(VM&, Value items, Vector const& element_types); ThrowCompletionOr get_options_object(VM&, Value options); ThrowCompletionOr get_option(VM&, Object const& options, PropertyKey const& property, OptionType type, Span values, OptionDefault const&); -ThrowCompletionOr to_temporal_overflow(VM&, Object const* options); +ThrowCompletionOr to_temporal_overflow(VM&, Object const* options); ThrowCompletionOr to_temporal_disambiguation(VM&, Object const* options); ThrowCompletionOr to_temporal_rounding_mode(VM&, Object const& normalized_options, DeprecatedString const& fallback); StringView negate_temporal_rounding_mode(DeprecatedString const& rounding_mode);