1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 21:07:34 +00:00

LibC: Primitively implement wcscoll

At the moment, sorting like LC_COLLATE=C would do is better than
nothing.
This commit is contained in:
Tim Schumacher 2021-09-17 01:14:17 +02:00 committed by Brian Gianforcaro
parent 8043fcd466
commit b8c756a53a
3 changed files with 50 additions and 3 deletions

View file

@ -15,6 +15,7 @@ set(TEST_SOURCES
TestStackSmash.cpp
TestStrlcpy.cpp
TestStrtodAccuracy.cpp
TestWchar.cpp
TestWctype.cpp
)

45
Tests/LibC/TestWchar.cpp Normal file
View file

@ -0,0 +1,45 @@
/*
* Copyright (c) 2021, the SerenityOS developers
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibTest/TestCase.h>
#include <wchar.h>
TEST_CASE(wcscoll)
{
// Check if wcscoll is sorting correctly. At the moment we are doing raw char comparisons,
// so it's digits, then uppercase letters, then lowercase letters.
// Equalness between equal strings.
EXPECT(wcscoll(L"", L"") == 0);
EXPECT(wcscoll(L"0", L"0") == 0);
// Shorter strings before longer strings.
EXPECT(wcscoll(L"", L"0") < 0);
EXPECT(wcscoll(L"0", L"") > 0);
EXPECT(wcscoll(L"123", L"1234") < 0);
EXPECT(wcscoll(L"1234", L"123") > 0);
// Order within digits.
EXPECT(wcscoll(L"0", L"9") < 0);
EXPECT(wcscoll(L"9", L"0") > 0);
// Digits before uppercase letters.
EXPECT(wcscoll(L"9", L"A") < 0);
EXPECT(wcscoll(L"A", L"9") > 0);
// Order within uppercase letters.
EXPECT(wcscoll(L"A", L"Z") < 0);
EXPECT(wcscoll(L"Z", L"A") > 0);
// Uppercase letters before lowercase letters.
EXPECT(wcscoll(L"Z", L"a") < 0);
EXPECT(wcscoll(L"a", L"Z") > 0);
// Uppercase letters before lowercase letters.
EXPECT(wcscoll(L"a", L"z") < 0);
EXPECT(wcscoll(L"z", L"a") > 0);
}

View file

@ -317,10 +317,11 @@ size_t wcrtomb(char*, wchar_t, mbstate_t*)
TODO();
}
int wcscoll(const wchar_t*, const wchar_t*)
int wcscoll(const wchar_t* ws1, const wchar_t* ws2)
{
dbgln("FIXME: Implement wcscoll()");
TODO();
// TODO: Actually implement a sensible sort order for this,
// because right now we are doing what LC_COLLATE=C would do.
return wcscmp(ws1, ws2);
}
int wctob(wint_t)