RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:17:34 +00:00
Code Issues Activity Actions

Piano: Handle octave slider jumps of greater than 1

Browse source 
The previous slider handler relied on the new value being 1 different
than the previous.

fixes #1163.
This commit is contained in:
Peter Elliott 2020-07-06 14:52:29 -06:00 • committed by Andreas Kling
parent 0fd31ef598
commit b8cf07166f
5 changed files with 20 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Applications/Piano/KnobsWidget.cpp
View file

@ -83,7 +83,7 @@ KnobsWidget::KnobsWidget(TrackManager& track_manager, MainWidget& main_widget)
m_octave_knob->on_value_changed = [this](int value) {
int new_octave = octave_max - value;
if (m_change_underlying)
m_main_widget.set_octave_and_ensure_note_change(new_octave == m_track_manager.octave() + 1 ? Up : Down);
m_main_widget.set_octave_and_ensure_note_change(new_octave);
ASSERT(new_octave == m_track_manager.octave());
m_octave_value->set_text(String::number(new_octave));
};