From b8d73e259cb90438f580165f58778a0cec00811f Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 5 Sep 2020 16:59:43 +0200 Subject: [PATCH] ClipboardHistory: Cap the history at 20 entries for now Now that we can copy bitmaps, we need some kind of cap here or memory usage quickly skyrockets. This could probably be improved or made adaptive somehow, this is just a simple hard cap for now. --- MenuApplets/ClipboardHistory/ClipboardHistoryModel.cpp | 2 ++ MenuApplets/ClipboardHistory/ClipboardHistoryModel.h | 1 + 2 files changed, 3 insertions(+) diff --git a/MenuApplets/ClipboardHistory/ClipboardHistoryModel.cpp b/MenuApplets/ClipboardHistory/ClipboardHistoryModel.cpp index 537e6c74dc..a99b0f35ef 100644 --- a/MenuApplets/ClipboardHistory/ClipboardHistoryModel.cpp +++ b/MenuApplets/ClipboardHistory/ClipboardHistoryModel.cpp @@ -71,6 +71,8 @@ void ClipboardHistoryModel::update() void ClipboardHistoryModel::add_item(const GUI::Clipboard::DataAndType& item) { + if (m_history_items.size() == m_history_limit) + m_history_items.take_last(); m_history_items.prepend(item); update(); } diff --git a/MenuApplets/ClipboardHistory/ClipboardHistoryModel.h b/MenuApplets/ClipboardHistory/ClipboardHistoryModel.h index 1309ccb583..f9a14e33c7 100644 --- a/MenuApplets/ClipboardHistory/ClipboardHistoryModel.h +++ b/MenuApplets/ClipboardHistory/ClipboardHistoryModel.h @@ -53,4 +53,5 @@ private: virtual void update() override; Vector m_history_items; + size_t m_history_limit { 20 }; };