RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 13:12:46 +00:00
Code Issues Activity Actions

Lagom+CMake: Propagate dependencies for generated custom targets

Browse source 
We have logic for serenity_generated_sources which works well for source
files that are specified in GENERATED_SOURCES prior to calling
serenity_lib or serenity_bin. However, code generated with
invoke_generator, and the LibWeb generators do not always follow the
pattern of the IDL and GML files.

For the LibWeb generators, we can just add_dependencies to LibWeb at the
time we declare the generate_Foo custom target. However for LibLocale,
LibTimeZone, and LibUnicode, we don't have the name of the target
available, so export the name in a variable to set into
GENERATED_SOURCES.

To make this work for Lagom, we need to make sure that lagom_lib and
serenity_bin in Lagom/CMakeLists.txt call serenity_generated_sources on
the target.

This enables the Xcode generator on macOS hosts, at least for Lagom.
This commit is contained in:
Andrew Kaster 2022-10-16 23:49:52 -06:00 • committed by Linus Groh
parent 8160b53228
commit b8e51425e9
6 changed files with 22 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Meta/CMake/utils.cmake
View file

@ -192,6 +192,8 @@ function(invoke_generator name generator version_file header implementation)
add_custom_target("generate_${name}" DEPENDS "${header}" "${implementation}")
add_dependencies(all_generated "generate_${name}")
list(APPEND CURRENT_LIB_GENERATED "${name}")
set(CURRENT_LIB_GENERATED ${CURRENT_LIB_GENERATED} PARENT_SCOPE)
endfunction()
function(download_file url path)