RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 13:47:35 +00:00
Code Issues Activity Actions

LibPDF: Allow pages with no specified contents

Browse source 
The contents object may be omitted as per spec, which will just leave
the page blank.
This commit is contained in:
Julian Offenhäuser 2023-03-24 22:12:31 +01:00 • committed by Andrew Kaster
parent fde990ead8
commit b90a794d78
3 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibPDF/Document.cpp
View file

@ -116,7 +116,9 @@ PDFErrorOr<Page> Document::get_page(u32 index)
else else
resources = adopt_ref(*new DictObject({})); resources = adopt_ref(*new DictObject({}));
auto contents = TRY(raw_page_object->get_object(this, CommonNames::Contents)); RefPtr<Object> contents;
if (raw_page_object->contains(CommonNames::Contents))
contents = TRY(raw_page_object->get_object(this, CommonNames::Contents));
Rectangle media_box; Rectangle media_box;
auto maybe_media_box_object = TRY(get_inheritable_object(CommonNames::MediaBox, raw_page_object)); auto maybe_media_box_object = TRY(get_inheritable_object(CommonNames::MediaBox, raw_page_object));

2
Userland/Libraries/LibPDF/Document.h
View file

@ -30,7 +30,7 @@ struct Rectangle {
struct Page { struct Page {
NonnullRefPtr<DictObject> resources; NonnullRefPtr<DictObject> resources;
NonnullRefPtr<Object> contents; RefPtr<Object> contents;
Rectangle media_box; Rectangle media_box;
Rectangle crop_box; Rectangle crop_box;
float user_unit; float user_unit;

3
Userland/Libraries/LibPDF/Renderer.cpp
View file

@ -85,6 +85,9 @@ Renderer::Renderer(RefPtr<Document> document, Page const& page, RefPtr<Gfx::Bitm
PDFErrorsOr<void> Renderer::render() PDFErrorsOr<void> Renderer::render()
{ {
if (m_page.contents.is_null())
return {};
// Use our own vector, as the /Content can be an array with multiple // Use our own vector, as the /Content can be an array with multiple
// streams which gets concatenated // streams which gets concatenated
// FIXME: Text operators are supposed to only have effects on the current // FIXME: Text operators are supposed to only have effects on the current