RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:07:36 +00:00
Code Issues Activity Actions

LibWeb: Destroy child navigables in Document::destroy()

Browse source
This commit is contained in:
Aliaksandr Kalenik 2023-09-02 23:19:28 +02:00 • committed by Andreas Kling
parent c3e2a40b76
commit b90dd9d1f8
1 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -2707,12 +2707,6 @@ void Document::destroy()
// 4. Abort document. // 4. Abort document.
abort(); abort();
// 1. Destroy the active documents of each of document's descendant navigables.
for (auto navigable : descendant_navigables()) {
if (auto document = navigable->active_document())
document->destroy();
}
// 2. Set document's salvageable state to false. // 2. Set document's salvageable state to false.
m_salvageable = false; m_salvageable = false;
@ -2726,6 +2720,15 @@ void Document::destroy()
// 6. Set document's browsing context to null. // 6. Set document's browsing context to null.
m_browsing_context = nullptr; m_browsing_context = nullptr;
// When a frame element stops being an active frame element, the user agent must destroy a child navigable given the element.
// A frame element is said to be an active frame element when it is in a document tree and its node document's browsing context is non-null.
for_each_shadow_including_descendant([&](DOM::Node& node) {
if (is<HTML::NavigableContainer>(node)) {
verify_cast<HTML::NavigableContainer>(node).destroy_the_child_navigable();
}
return IterationDecision::Continue;
});
// 7. Set document's node navigable's active session history entry's document state's document to null. // 7. Set document's node navigable's active session history entry's document state's document to null.
if (navigable()) { if (navigable()) {
navigable()->active_session_history_entry()->document_state->set_document(nullptr); navigable()->active_session_history_entry()->document_state->set_document(nullptr);