RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 06:38:10 +00:00
Code Issues Activity Actions

LibJS: Disallow changing the prototype of non-extensible objects

Browse source 
Object::set_prototype() now returns a boolean indicating success.
Setting the prototype to an identical object is always considered
successful, even if the object is non-extensible.
This commit is contained in:
Linus Groh 2020-06-02 12:32:54 +01:00 • committed by Andreas Kling
parent 8cf1ded478
commit b958e4f573
4 changed files with 22 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibJS/Runtime/Object.cpp
View file

@ -69,15 +69,18 @@ const Object* Object::prototype() const
return shape().prototype();
}
void Object::set_prototype(Object* new_prototype)
bool Object::set_prototype(Object* new_prototype)
{
if (prototype() == new_prototype)
return;
return true;
if (!m_is_extensible)
return false;
if (shape().is_unique()) {
shape().set_prototype_without_transition(new_prototype);
return;
return true;
}
m_shape = m_shape->create_prototype_transition(new_prototype);
return true;
}
bool Object::has_prototype(const Object* prototype) const