RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:47:34 +00:00
Code Issues Activity Actions

Kernel: Use try_copy_kstring_from_user() in IPv4Socket::ioctl()

Browse source
This commit is contained in:
Andreas Kling 2021-08-05 23:09:21 +02:00
parent 584fa525eb
commit b96ad76cba
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Kernel/Net/IPv4Socket.cpp
View file

@ -589,11 +589,11 @@ KResult IPv4Socket::ioctl(FileDescription&, unsigned request, Userspace<void*> a
if (!copy_from_user(&route, user_route)) if (!copy_from_user(&route, user_route))
return EFAULT; return EFAULT;
auto copied_ifname = copy_string_from_user(route.rt_dev, IFNAMSIZ); auto ifname_or_error = try_copy_kstring_from_user(route.rt_dev, IFNAMSIZ);
if (copied_ifname.is_null()) if (ifname_or_error.is_error())
return EFAULT; return ifname_or_error.error();
auto adapter = NetworkingManagement::the().lookup_by_name(copied_ifname); auto adapter = NetworkingManagement::the().lookup_by_name(ifname_or_error.value()->view());
if (!adapter) if (!adapter)
return ENODEV; return ENODEV;