RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:57:45 +00:00
Code Issues Activity Actions

Kernel/VM: Make local_offset in PhysicalRegion::find_one_free_page unsigned

Browse source 
An extension to #4613, as I didn't notice that it also happens here.
This commit is contained in:
Luke 2020-12-29 01:14:08 +00:00 • committed by Andreas Kling
parent eb38fe4a82
commit b980782343
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Kernel/VM/PhysicalRegion.cpp
View file

@ -96,11 +96,12 @@ Optional<unsigned> PhysicalRegion::find_one_free_page()
// Check if we can draw one from the return queue // Check if we can draw one from the return queue
if (m_recently_returned.size() > 0) { if (m_recently_returned.size() > 0) {
u8 index = get_fast_random<u8>() % m_recently_returned.size(); u8 index = get_fast_random<u8>() % m_recently_returned.size();
ptrdiff_t local_offset = m_recently_returned[index].get() - m_lower.get(); Checked<FlatPtr> local_offset = m_recently_returned[index].get();
local_offset -= m_lower.get();
m_recently_returned.remove(index); m_recently_returned.remove(index);
ASSERT(local_offset >= 0); ASSERT(!local_offset.has_overflow());
ASSERT((FlatPtr)local_offset < (FlatPtr)(m_pages * PAGE_SIZE)); ASSERT(local_offset.value() < (FlatPtr)(m_pages * PAGE_SIZE));
return local_offset / PAGE_SIZE; return local_offset.value() / PAGE_SIZE;
} }
return {}; return {};
} }