From b98c77229dbdac7b044c7b41b7fa79bb260b7b19 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 27 Jul 2019 21:20:38 +0200 Subject: [PATCH] TextEditor: Let's have line numbers starting at 1. Thanks to Dan for pointing this out on IRC: I see TextEditor still numbers its lines from 0. You're too much of a programmer sometimes kling! :) < kling> that might be the most extreme form of "programmer design" I've seen in serenity --- Applications/TextEditor/TextEditorWidget.cpp | 2 +- Libraries/LibGUI/GTextEditor.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Applications/TextEditor/TextEditorWidget.cpp b/Applications/TextEditor/TextEditorWidget.cpp index 3d5135fd7e..91f25f6384 100644 --- a/Applications/TextEditor/TextEditorWidget.cpp +++ b/Applications/TextEditor/TextEditorWidget.cpp @@ -25,7 +25,7 @@ TextEditorWidget::TextEditorWidget() m_editor->on_cursor_change = [statusbar, this] { StringBuilder builder; - builder.appendf("Line: %d, Column: %d", m_editor->cursor().line(), m_editor->cursor().column()); + builder.appendf("Line: %d, Column: %d", m_editor->cursor().line() + 1, m_editor->cursor().column()); statusbar->set_text(builder.to_string()); }; diff --git a/Libraries/LibGUI/GTextEditor.cpp b/Libraries/LibGUI/GTextEditor.cpp index 468495af9e..60b0c703e6 100644 --- a/Libraries/LibGUI/GTextEditor.cpp +++ b/Libraries/LibGUI/GTextEditor.cpp @@ -292,7 +292,7 @@ void GTextEditor::paint_event(GPaintEvent& event) auto ruler_line_rect = ruler_content_rect(i); painter.draw_text( ruler_line_rect.shrunken(2, 0), - String::number(i), + String::number(i + 1), is_current_line ? Font::default_bold_font() : font(), TextAlignment::CenterRight, is_current_line ? Color::DarkGray : Color::MidGray);