RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:57:35 +00:00
Code Issues Activity Actions

LibJS: Assign getter/setter function names as early as possible

Browse source 
In case of {get func() {}, set func() {}} we were wrongly setting the
function name to 'func' and then later trying to replace an empty name
with 'get func'/'set func' which failed.

Instead, set the name to 'get func'/'set func' right away.
The code in put_by_property_key is kept, for when that is called
by put_by_value.
This commit is contained in:
Simon Wanner 2023-11-05 11:21:32 +01:00 • committed by Andreas Kling
parent a3f34263fd
commit b9c9315bcb
2 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
View file

@ -976,7 +976,12 @@ Bytecode::CodeGenerationErrorOr<void> ObjectExpression::generate_bytecode(Byteco
if (property_kind == Bytecode::Op::PropertyKind::ProtoSetter) { if (property_kind == Bytecode::Op::PropertyKind::ProtoSetter) {
TRY(property->value().generate_bytecode(generator)); TRY(property->value().generate_bytecode(generator));
} else if (property_kind != Bytecode::Op::PropertyKind::Spread) { } else if (property_kind != Bytecode::Op::PropertyKind::Spread) {
auto name = generator.intern_identifier(string_literal.value()); DeprecatedString identifier = string_literal.value();
if (property_kind == Bytecode::Op::PropertyKind::Getter)
identifier = DeprecatedString::formatted("get {}", identifier);
else if (property_kind == Bytecode::Op::PropertyKind::Setter)
identifier = DeprecatedString::formatted("set {}", identifier);
auto name = generator.intern_identifier(identifier);
TRY(generator.emit_named_evaluation_if_anonymous_function(property->value(), name)); TRY(generator.emit_named_evaluation_if_anonymous_function(property->value(), name));
} }

4
Userland/Libraries/LibJS/Tests/object-basic.js
View file

@ -221,13 +221,13 @@ describe("naming of anon functions", () => {
expect({ func() {} }.func.name).toBe("func"); expect({ func() {} }.func.name).toBe("func");
}); });
test.xfail("getter has name", () => { test("getter has name", () => {
expect(Object.getOwnPropertyDescriptor({ get func() {} }, "func").get.name).toBe( expect(Object.getOwnPropertyDescriptor({ get func() {} }, "func").get.name).toBe(
"get func" "get func"
); );
}); });
test.xfail("setter has name", () => { test("setter has name", () => {
expect(Object.getOwnPropertyDescriptor({ set func(v) {} }, "func").set.name).toBe( expect(Object.getOwnPropertyDescriptor({ set func(v) {} }, "func").set.name).toBe(
"set func" "set func"
); );