RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:37:44 +00:00
Code Issues Activity Actions

LibJS: Increase free stack space required for function calls to 32 kiB

Browse source 
The previous 16 kiB weren't sufficient with ASAN enabled and would
trigger stack overflow failures.
This commit is contained in:
Linus Groh 2021-05-17 18:03:10 +01:00
parent 0aab774343
commit b9d3df70e0
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/VM.h
View file

@ -96,8 +96,8 @@ public:
{
VERIFY(!exception());
// Ensure we got some stack space left, so the next function call doesn't kill us.
// This value is merely a guess and might need tweaking at a later point.
if (m_stack_info.size_free() < 16 * KiB)
// Note: the 32 kiB used to be 16 kiB, but that turned out to not be enough with ASAN enabled.
if (m_stack_info.size_free() < 32 * KiB)
throw_exception<Error>(global_object, "Call stack size limit exceeded");
else
m_call_stack.append(&call_frame);