RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 02:07:34 +00:00
Code Issues Activity Actions

LibGUI: Always reset pressed close button index on mouse up in TabWidget

Browse source 
Previously it would only do this if the mouse was over the close 
button.

If you released the mouse outside the close button, the close button
would appear permanently depressed afterwards.
This commit is contained in:
Luke 2021-07-28 00:24:18 +01:00 • committed by Andreas Kling
parent b3d27c2340
commit b9d51b8601
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/TabWidget.cpp
View file

@ -362,6 +362,7 @@ void TabWidget::mouseup_event(MouseEvent& event)
return;
auto close_button_rect = this->close_button_rect(m_pressed_close_button_index);
m_pressed_close_button_index = -1;
if (close_button_rect.contains(event.position())) {
auto* widget = m_tabs[m_pressed_close_button_index].widget;
@ -369,7 +370,6 @@ void TabWidget::mouseup_event(MouseEvent& event)
if (on_tab_close_click && widget)
on_tab_close_click(*widget);
});
m_pressed_close_button_index = -1;
return;
}
}