RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:57:44 +00:00
Code Issues Activity Actions

LibJS: Revoke any outstanding WeakPtr<Shape> when zombifying shapes

Browse source 
The forward transition cache in Shape uses WeakPtr<Shape> to learn when
a cached transition has been garbage collected.

When running in zombification mode, we have to explicitly revoke any
outstanding WeakPtrs to a Shape when it becomes a zombie. That ensures
that it gets pruned from transition caches.
This commit is contained in:
Andreas Kling 2021-09-11 17:01:45 +02:00
parent cd7dbe3e97
commit b9eb8d00ca
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibJS/Runtime/Shape.cpp
View file

@ -221,4 +221,9 @@ FLATTEN void Shape::add_property_without_transition(PropertyName const& property
add_property_without_transition(property_name.to_string_or_symbol(), attributes);
}
void Shape::did_become_zombie()
{
revoke_weak_ptrs();
}
}

1
Userland/Libraries/LibJS/Runtime/Shape.h
View file

@ -88,6 +88,7 @@ public:
private:
virtual const char* class_name() const override { return "Shape"; }
virtual void visit_edges(Visitor&) override;
virtual void did_become_zombie() override;
Shape* get_or_prune_cached_forward_transition(TransitionKey const&);
void ensure_property_table() const;