RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 06:47:40 +00:00
Code Issues Activity Actions

Kernel: Remove outdated FIXME's in the static ACPI parser

Browse source 
We no longer blindly use PAGE_SIZE here. :^)
This commit is contained in:
Andreas Kling 2020-05-22 13:37:57 +02:00
parent 4b847810bf
commit ba390f9b34
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/ACPI/Parser.cpp
View file

@ -345,7 +345,6 @@ Optional<PhysicalAddress> StaticParsing::find_rsdp()
PhysicalAddress StaticParsing::find_table(PhysicalAddress rsdp_address, const StringView& signature) PhysicalAddress StaticParsing::find_table(PhysicalAddress rsdp_address, const StringView& signature)
{ {
// FIXME: There's no validation of ACPI tables here. Use the checksum to validate the tables. // FIXME: There's no validation of ACPI tables here. Use the checksum to validate the tables.
// FIXME: Don't blindly use PAGE_SIZE here, but probe the actual length.
ASSERT(signature.length() == 4); ASSERT(signature.length() == 4);
auto rsdp = map_typed<Structures::RSDPDescriptor20>(rsdp_address); auto rsdp = map_typed<Structures::RSDPDescriptor20>(rsdp_address);
@ -364,7 +363,6 @@ PhysicalAddress StaticParsing::find_table(PhysicalAddress rsdp_address, const St
static PhysicalAddress search_table_in_xsdt(PhysicalAddress xsdt_address, const StringView& signature) static PhysicalAddress search_table_in_xsdt(PhysicalAddress xsdt_address, const StringView& signature)
{ {
// FIXME: There's no validation of ACPI tables here. Use the checksum to validate the tables. // FIXME: There's no validation of ACPI tables here. Use the checksum to validate the tables.
// FIXME: Don't blindly use PAGE_SIZE here, but probe the actual length.
ASSERT(signature.length() == 4); ASSERT(signature.length() == 4);
auto xsdt = map_typed<Structures::XSDT>(xsdt_address); auto xsdt = map_typed<Structures::XSDT>(xsdt_address);
@ -379,7 +377,6 @@ static PhysicalAddress search_table_in_xsdt(PhysicalAddress xsdt_address, const
static bool match_table_signature(PhysicalAddress table_header, const StringView& signature) static bool match_table_signature(PhysicalAddress table_header, const StringView& signature)
{ {
// FIXME: There's no validation of ACPI tables here. Use the checksum to validate the tables. // FIXME: There's no validation of ACPI tables here. Use the checksum to validate the tables.
// FIXME: Don't blindly use PAGE_SIZE here, but probe the actual length.
ASSERT(signature.length() == 4); ASSERT(signature.length() == 4);
auto table = map_typed<Structures::RSDT>(table_header); auto table = map_typed<Structures::RSDT>(table_header);
@ -389,7 +386,6 @@ static bool match_table_signature(PhysicalAddress table_header, const StringView
static PhysicalAddress search_table_in_rsdt(PhysicalAddress rsdt_address, const StringView& signature) static PhysicalAddress search_table_in_rsdt(PhysicalAddress rsdt_address, const StringView& signature)
{ {
// FIXME: There's no validation of ACPI tables here. Use the checksum to validate the tables. // FIXME: There's no validation of ACPI tables here. Use the checksum to validate the tables.
// FIXME: Don't blindly use PAGE_SIZE here, but probe the actual length.
ASSERT(signature.length() == 4); ASSERT(signature.length() == 4);
auto rsdt = map_typed<Structures::RSDT>(rsdt_address); auto rsdt = map_typed<Structures::RSDT>(rsdt_address);