From ba76a724221ec63c3f127d77d031524ed1236a16 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Fri, 26 Jun 2020 15:09:14 +0200 Subject: [PATCH] LibWeb: Skip over floating elements when collapsing margins Two sibling blocks are not vertically adjacent if one is float:left and the other is float:none. Respect this when collapsing margins. --- Libraries/LibWeb/Layout/LayoutBlock.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/LibWeb/Layout/LayoutBlock.cpp b/Libraries/LibWeb/Layout/LayoutBlock.cpp index 65579994e1..101bc42202 100644 --- a/Libraries/LibWeb/Layout/LayoutBlock.cpp +++ b/Libraries/LibWeb/Layout/LayoutBlock.cpp @@ -627,7 +627,7 @@ void LayoutBlock::place_block_level_non_replaced_element_in_normal_flow(LayoutBl auto* relevant_sibling = block.previous_sibling(); while (relevant_sibling != nullptr) { - if (!relevant_sibling->is_absolutely_positioned()) + if (!relevant_sibling->is_absolutely_positioned() && !relevant_sibling->is_floating()) break; relevant_sibling = relevant_sibling->previous_sibling(); }