CI: Split off clang toolchain builds from normal CI and schedule them

Clang builds will no longer be apart of the automated CI for every Push/
Pull Request, and will instead be ran at 00:00 UTC every day, with the
results posted to the discord #clang-toolchain channel.

.github/workflows/clang.yml

@@ -0,0 +1,99 @@
+name: Clang toolchain status
+on:
+  schedule:
+    - cron: '0 0 * * *'
+
+jobs:
+  build_and_test_serenity:
+    runs-on: ubuntu-20.04
+    strategy:
+      fail-fast: false
+      matrix:
+        arch: [ 'i686', 'x86_64' ]
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Install Ubuntu dependencies
+        run: |
+          sudo add-apt-repository ppa:canonical-server/server-backports
+          sudo apt-get update
+          sudo apt-get install libmpfr-dev libmpc-dev ninja-build e2fsprogs qemu-utils qemu-system-i386
+
+      - name: Check versions
+        run: set +e; g++ --version; g++-10 --version; ninja --version; qemu-system-i386 --version
+
+      - name: Regenerate Toolchain
+        run: TRY_USE_LOCAL_TOOLCHAIN=y ARCH="${{ matrix.arch }}" ${{ github.workspace }}/Toolchain/BuildClang.sh
+
+      - name: Create build directory
+        run: |
+          mkdir -p ${{ github.workspace }}/Build
+          mkdir -p ${{ github.workspace }}/Build/UCD
+
+      - name: UnicodeData cache
+        # TODO: Change the version to the released version when https://github.com/actions/cache/pull/489 (or 571) is merged.
+        uses: actions/cache@03e00da99d75a2204924908e1cca7902cafce66b
+        with:
+          path: ${{ github.workspace }}/Build/UCD
+          key: UnicodeData-${{ hashFiles('Userland/Libraries/LibUnicode/unicode_data.cmake') }}
+
+      - name: Create build environment
+        working-directory: ${{ github.workspace }}/Build
+        run: cmake .. -GNinja -DSERENITY_ARCH=${{ matrix.arch }} -DUSE_CLANG_TOOLCHAIN=ON -DENABLE_UNDEFINED_SANITIZER=ON -DENABLE_PCI_IDS_DOWNLOAD=OFF -DENABLE_USB_IDS_DOWNLOAD=OFF -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_CXX_COMPILER=g++-10
+
+      - name: Build Serenity and Tests
+        working-directory: ${{ github.workspace }}/Build
+        run: cmake --build .
+      - name: Show ccache stats after build
+        run: ccache -s
+
+      - name: Create Serenity Rootfs
+        working-directory: ${{ github.workspace }}/Build
+        run: ninja install && ninja image
+
+      - name: Run On-Target Tests
+        working-directory: ${{ github.workspace }}/Build
+        env:
+          SERENITY_QEMU_CPU: "max,vmx=off"
+          SERENITY_KERNEL_CMDLINE: "boot_mode=self-test"
+          SERENITY_RUN: "ci"
+        run: |
+          echo "::group::ninja run # Qemu output"
+          ninja run
+          echo "::endgroup::"
+          echo "::group::Verify Output File"
+          mkdir fsmount
+          sudo mount -t ext2 -o loop,rw _disk_image fsmount
+          echo "Results: "
+          sudo cat fsmount/home/anon/test-results.log
+          if ! sudo grep -q "Failed: 0" fsmount/home/anon/test-results.log
+          then
+            echo "::error :^( Tests failed, failing job"
+            exit 1
+          fi
+          echo "::endgroup::"
+        timeout-minutes: 60
+
+      - name: Print Target Logs
+        # Extremely useful if Serenity hangs trying to run one of the tests
+        if: ${{ !cancelled() }}
+        working-directory: ${{ github.workspace }}/Build
+        run: '[ ! -e debug.log ] || cat debug.log'
+
+  notify_discord:
+    runs-on: ubuntu-20.04
+    needs: build_and_test_serenity
+    if: always()
+    steps:
+      - uses: actions/checkout@v2
+      - uses: technote-space/workflow-conclusion-action@v2
+      - name: Send discord notification
+        env:
+          DISCORD_WEBHOOK: ${{ secrets.DISCORD_CLANG_WEBHOOK }}
+          DISCORD_USERNAME: GitHub # we have to set these manually for non-default messages
+          DISCORD_AVATAR: https://github.githubassets.com/images/modules/logos_page/GitHub-Mark.png
+        uses: IdanHo/action-discord@754598254f288e6d8e9fca637832e3c163515ba8
+        with:
+          args: "The clang build ${{ env.WORKFLOW_CONCLUSION == 'success' && 'passed :white_check_mark:' || 'failed :x:' }} :( https://github.com/SerenityOS/serenity/runs/${{github.run_id}}"
+

.github/workflows/cmake.yml

@@ -21,15 +21,12 @@ jobs:
         debug-options: ['ALL_DEBUG', 'NORMAL_DEBUG']
         os: [ubuntu-20.04]
         arch: ['i686', 'x86_64']
-        compiler: ['GCC', 'Clang']
         # If ccache is broken and you would like to bust the ccache cache on Github Actions, increment this:
         ccache-mark: [0]
         exclude:
           # We currently manually disable the ALL_DEBUG build on x86_64 for sake of saving CI time, as it is not our main target right now
           - debug-options: 'ALL_DEBUG'
             arch: 'x86_64'
-          - debug-options: 'ALL_DEBUG'
-            compiler: 'Clang'
 
     steps:
       - uses: actions/checkout@v2
@@ -76,6 +73,7 @@ jobs:
           message("::set-output name=time::${current_date}")
           message("  set-output name=libc_headers::${{ hashFiles('Userland/Libraries/LibC/**/*.h', 'Userland/Libraries/LibPthread/**/*.h', 'Toolchain/Patches/*.patch', 'Toolchain/BuildIt.sh') }}")
           message("::set-output name=libc_headers::${{ hashFiles('Userland/Libraries/LibC/**/*.h', 'Userland/Libraries/LibPthread/**/*.h', 'Toolchain/Patches/*.patch', 'Toolchain/BuildIt.sh') }}")
+
       - name: Toolchain cache
         # TODO: Change the version to the released version when https://github.com/actions/cache/pull/489 (or 571) is merged.
         uses: actions/cache@03e00da99d75a2204924908e1cca7902cafce66b
@@ -86,13 +84,11 @@ jobs:
           # This assumes that *ALL* LibC and LibPthread headers have an impact on the Toolchain.
           # This is wrong, and causes more Toolchain rebuilds than necessary.
           # However, we want to avoid false cache hits at all costs.
-        key: ${{ runner.os }}-toolchain-${{ matrix.arch }}-${{ matrix.compiler }}-${{ steps.stamps.outputs.libc_headers }}
+          key: ${{ runner.os }}-toolchain-${{ matrix.arch }}-${{ steps.stamps.outputs.libc_headers }}
-    - name: Restore or regenerate GCC Toolchain
+
+      - name: Restore or regenerate Toolchain
         run: TRY_USE_LOCAL_TOOLCHAIN=y ARCH="${{ matrix.arch }}" ${{ github.workspace }}/Toolchain/BuildIt.sh
-      if: ${{ matrix.compiler == 'GCC' }}
+
-    - name: Restore or regenerate Clang Toolchain
-      run: TRY_USE_LOCAL_TOOLCHAIN=y ARCH="${{ matrix.arch }}" ${{ github.workspace }}/Toolchain/BuildClang.sh
-      if: ${{ matrix.compiler == 'Clang' }}
       - name: ccache(1) cache
         # Pull the ccache *after* building the toolchain, in case building the Toolchain somehow interferes.
         # TODO: Change the version to the released version when https://github.com/actions/cache/pull/489 (or 571) is merged.
@@ -106,10 +102,10 @@ jobs:
           # This is achieved by using the "prefix-timestamp" format,
           # and permitting the restore-key "prefix-" without specifying a timestamp.
           # For this trick to work, the timestamp *must* come last, and it *must* be missing in 'restore-keys'.
-        key: ${{ runner.os }}-ccache-${{ matrix.arch }}-${{ matrix.compiler }}-v${{ matrix.ccache-mark }}-D${{ matrix.debug-options }}-toolchain_${{steps.stamps.outputs.libc_headers}}-time${{ steps.stamps.outputs.time }}
+          key: ${{ runner.os }}-ccache-${{ matrix.arch }}-v${{ matrix.ccache-mark }}-D${{ matrix.debug-options }}-toolchain_${{steps.stamps.outputs.libc_headers}}-time${{ steps.stamps.outputs.time }}
-        # IMPORTANT: Keep these two in sync!
           restore-keys: |
-          ${{ runner.os }}-ccache-${{ matrix.arch }}-${{ matrix.compiler }}-v${{ matrix.ccache-mark }}-D${{ matrix.debug-options }}-toolchain_${{steps.stamps.outputs.libc_headers}}-
+            ${{ runner.os }}-ccache-${{ matrix.arch }}-v${{ matrix.ccache-mark }}-D${{ matrix.debug-options }}-toolchain_${{steps.stamps.outputs.libc_headers}}-
+
       - name: Show ccache stats before build and configure
         run: |
           # We only have 5 GiB of cache available *in total*. Beyond that, GitHub deletes caches.
@@ -134,13 +130,13 @@ jobs:
         working-directory: ${{ github.workspace }}/Build
         # Build the entire project with all available debug options turned on, to prevent code rot.
         # However, it is unweildy and slow to run tests with them enabled, so we will build twice.
-      run: cmake .. -GNinja -DSERENITY_ARCH=${{ matrix.arch }} -DUSE_CLANG_TOOLCHAIN=${{ matrix.compiler == 'Clang' }} -DBUILD_LAGOM=ON -DENABLE_ALL_DEBUG_FACILITIES=ON -DENABLE_PCI_IDS_DOWNLOAD=OFF -DENABLE_USB_IDS_DOWNLOAD=OFF -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_CXX_COMPILER=g++-10
+        run: cmake .. -GNinja -DSERENITY_ARCH=${{ matrix.arch }} -DBUILD_LAGOM=ON -DENABLE_ALL_DEBUG_FACILITIES=ON -DENABLE_PCI_IDS_DOWNLOAD=OFF -DENABLE_USB_IDS_DOWNLOAD=OFF -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_CXX_COMPILER=g++-10
         if: ${{ matrix.debug-options == 'ALL_DEBUG' }}
       - name: Create build environment
         working-directory: ${{ github.workspace }}/Build
         # Note that we do not set BUILD_LAGOM for the normal debug build
         # We build and run the Lagom tests in a separate job, and sanitizer builds take a good while longer than non-sanitized.
-      run: cmake .. -GNinja -DSERENITY_ARCH=${{ matrix.arch }} -DUSE_CLANG_TOOLCHAIN=${{ matrix.compiler == 'Clang' }} -DENABLE_UNDEFINED_SANITIZER=ON -DENABLE_PCI_IDS_DOWNLOAD=OFF -DENABLE_USB_IDS_DOWNLOAD=OFF -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_CXX_COMPILER=g++-10
+        run: cmake .. -GNinja -DSERENITY_ARCH=${{ matrix.arch }} -DENABLE_UNDEFINED_SANITIZER=ON -DENABLE_PCI_IDS_DOWNLOAD=OFF -DENABLE_USB_IDS_DOWNLOAD=OFF -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_CXX_COMPILER=g++-10
         if: ${{ matrix.debug-options == 'NORMAL_DEBUG' }}
 
       # === ACTUALLY BUILD ===