RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:07:47 +00:00
Code Issues Activity Actions

LibJS: Add the String.prototype.matchAll method

Browse source 
This is only the String.prototype side of matchAll, for full
functionality Symbol.matchAll has to be implemented in our RegExp
built-in object.
This commit is contained in:
Idan Horowitz 2021-06-16 17:48:39 +03:00 • committed by Linus Groh
parent 8e05b49089
commit bad2108d3c
3 changed files with 43 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibJS/Runtime/ErrorTypes.h
View file

@ -145,6 +145,7 @@
M(RegExpObjectRepeatedFlag, "Repeated RegExp flag '{}'") \
M(SpeciesConstructorDidNotCreate, "Species constructor did not create {}") \
M(SpeciesConstructorReturned, "Species constructor returned {}") \
M(StringMatchAllNonGlobalRegExp, "RegExp argument is non-global") \
M(StringRawCannotConvert, "Cannot convert property 'raw' to object from {}") \
M(StringRepeatCountMustBe, "repeat count must be a {} number") \
M(ThisHasNotBeenInitialized, "|this| has not been initialized") \

41
Userland/Libraries/LibJS/Runtime/StringPrototype.cpp
View file

@ -79,6 +79,7 @@ void StringPrototype::initialize(GlobalObject& global_object)
define_native_function(vm.names.lastIndexOf, last_index_of, 1, attr);
define_native_function(vm.names.at, at, 1, attr);
define_native_function(vm.names.match, match, 1, attr);
define_native_function(vm.names.matchAll, match_all, 1, attr);
define_native_function(vm.names.replace, replace, 2, attr);
define_native_function(vm.names.anchor, anchor, 1, attr);
define_native_function(vm.names.big, big, 0, attr);
@ -711,6 +712,46 @@ JS_DEFINE_NATIVE_FUNCTION(StringPrototype::match)
return rx->invoke(vm.well_known_symbol_match(), js_string(vm, s));
}
// 22.1.3.12 String.prototype.matchAll ( regexp ), https://tc39.es/ecma262/#sec-string.prototype.matchall
JS_DEFINE_NATIVE_FUNCTION(StringPrototype::match_all)
{
auto this_object = require_object_coercible(global_object, vm.this_value(global_object));
if (vm.exception())
return {};
auto regexp = vm.argument(0);
if (!regexp.is_nullish()) {
auto is_regexp = regexp.is_regexp(global_object);
if (vm.exception())
return {};
if (is_regexp) {
auto flags = regexp.as_object().get("flags").value_or(js_undefined());
if (vm.exception())
return {};
auto flags_object = require_object_coercible(global_object, flags);
if (vm.exception())
return {};
auto flags_string = flags_object.to_string(global_object);
if (vm.exception())
return {};
if (!flags_string.contains("g")) {
vm.throw_exception<TypeError>(global_object, ErrorType::StringMatchAllNonGlobalRegExp);
return {};
}
}
if (auto* matcher = get_method(global_object, regexp, vm.well_known_symbol_match_all()))
return vm.call(*matcher, regexp, this_object);
if (vm.exception())
return {};
}
auto s = this_object.to_string(global_object);
if (vm.exception())
return {};
auto rx = regexp_create(global_object, regexp, js_string(vm, "g"));
if (!rx)
return {};
return rx->invoke(vm.well_known_symbol_match_all(), js_string(vm, s));
}
// 22.1.3.17 String.prototype.replace ( searchValue, replaceValue ), https://tc39.es/ecma262/#sec-string.prototype.replace
JS_DEFINE_NATIVE_FUNCTION(StringPrototype::replace)
{

1
Userland/Libraries/LibJS/Runtime/StringPrototype.h
View file

@ -44,6 +44,7 @@ private:
JS_DECLARE_NATIVE_FUNCTION(last_index_of);
JS_DECLARE_NATIVE_FUNCTION(at);
JS_DECLARE_NATIVE_FUNCTION(match);
JS_DECLARE_NATIVE_FUNCTION(match_all);
JS_DECLARE_NATIVE_FUNCTION(replace);
JS_DECLARE_NATIVE_FUNCTION(anchor);
JS_DECLARE_NATIVE_FUNCTION(big);