RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:27:44 +00:00
Code Issues Activity Actions

LibJS: Convert create_method_property() to ThrowCompletionOr

Browse source
This commit is contained in:
Linus Groh 2021-10-03 00:54:25 +01:00
parent fb443b3fb4
commit bb2499cd7a
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/Object.cpp
View file

@ -137,7 +137,7 @@ ThrowCompletionOr<bool> Object::create_data_property(PropertyName const& propert
} }
// 7.3.6 CreateMethodProperty ( O, P, V ), https://tc39.es/ecma262/#sec-createmethodproperty // 7.3.6 CreateMethodProperty ( O, P, V ), https://tc39.es/ecma262/#sec-createmethodproperty
bool Object::create_method_property(PropertyName const& property_name, Value value) ThrowCompletionOr<bool> Object::create_method_property(PropertyName const& property_name, Value value)
{ {
VERIFY(!value.is_empty()); VERIFY(!value.is_empty());
@ -155,7 +155,7 @@ bool Object::create_method_property(PropertyName const& property_name, Value val
}; };
// 4. Return ? O.[[DefineOwnProperty]](P, newDesc). // 4. Return ? O.[[DefineOwnProperty]](P, newDesc).
return TRY_OR_DISCARD(internal_define_own_property(property_name, new_descriptor)); return internal_define_own_property(property_name, new_descriptor);
} }
// 7.3.7 CreateDataPropertyOrThrow ( O, P, V ), https://tc39.es/ecma262/#sec-createdatapropertyorthrow // 7.3.7 CreateDataPropertyOrThrow ( O, P, V ), https://tc39.es/ecma262/#sec-createdatapropertyorthrow

2
Userland/Libraries/LibJS/Runtime/Object.h
View file

@ -78,7 +78,7 @@ public:
ThrowCompletionOr<Value> get(PropertyName const&) const; ThrowCompletionOr<Value> get(PropertyName const&) const;
ThrowCompletionOr<bool> set(PropertyName const&, Value, ShouldThrowExceptions); ThrowCompletionOr<bool> set(PropertyName const&, Value, ShouldThrowExceptions);
ThrowCompletionOr<bool> create_data_property(PropertyName const&, Value); ThrowCompletionOr<bool> create_data_property(PropertyName const&, Value);
bool create_method_property(PropertyName const&, Value); ThrowCompletionOr<bool> create_method_property(PropertyName const&, Value);
bool create_data_property_or_throw(PropertyName const&, Value); bool create_data_property_or_throw(PropertyName const&, Value);
bool create_non_enumerable_data_property_or_throw(PropertyName const&, Value); bool create_non_enumerable_data_property_or_throw(PropertyName const&, Value);
bool define_property_or_throw(PropertyName const&, PropertyDescriptor const&); bool define_property_or_throw(PropertyName const&, PropertyDescriptor const&);