mirror of
https://github.com/RGBCube/serenity
synced 2025-05-28 08:55:06 +00:00
Shell: Improve readability of cache_path()
I prefer String::format over StringBuilder here. Also simplified a weird continue statement.
This commit is contained in:
parent
c0696ad3aa
commit
bb311b970f
2 changed files with 4 additions and 11 deletions
|
@ -51,17 +51,11 @@ void LineEditor::cache_path()
|
|||
CDirIterator programs(directory.characters(), CDirIterator::SkipDots);
|
||||
while (programs.has_next()) {
|
||||
auto program = programs.next_path();
|
||||
|
||||
StringBuilder program_path;
|
||||
program_path.append(directory.characters());
|
||||
program_path.append('/');
|
||||
program_path.append(program.characters());
|
||||
String program_path = String::format("%s/%s", directory.characters(), program.characters());
|
||||
struct stat program_status;
|
||||
int stat_error = stat(program_path.to_string().characters(), &program_status);
|
||||
if (stat_error || !(program_status.st_mode & S_IXUSR))
|
||||
continue;
|
||||
|
||||
m_path.append(program.characters());
|
||||
int stat_error = stat(program_path.characters(), &program_status);
|
||||
if (!stat_error && (program_status.st_mode & S_IXUSR))
|
||||
m_path.append(program.characters());
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue