RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 00:47:45 +00:00
Code Issues Activity Actions

Everywhere: Name debug macros more consistently.

Browse source 
Personally, I prefer the naming convention DEBUG_FOO over FOO_DEBUG, but
the majority of the debug macros are already named in the latter naming
convention, so I just enforce consistency here.

This was done with the following script:

    find . \( -name '*.cpp' -o -name '*.h' -o -name '*.in' \) -not -path './Toolchain/*' -not -path './Build/*' -exec sed -i -E 's/DEBUG_PATH/PATH_DEBUG/' {} \;
This commit is contained in:
asynts 2021-01-23 23:52:21 +01:00 • committed by Andreas Kling
parent acdcf59a33
commit bb483f7ef4
9 changed files with 44 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibCore/Gzip.cpp
View file

@ -52,7 +52,7 @@ static Optional<ByteBuffer> get_gzip_payload(const ByteBuffer& data)
return data[current++];
};
#if DEBUG_GZIP
#if GZIP_DEBUG
dbgln("get_gzip_payload: Skipping over gzip header.");
#endif
@ -135,7 +135,7 @@ Optional<ByteBuffer> Gzip::decompress(const ByteBuffer& data)
source.data(), &source_len);
if (puff_ret == 0) {
#if DEBUG_GZIP
#if GZIP_DEBUG
dbgln("Gzip::decompress: Decompression success.");
#endif
destination.trim(destination_len);
@ -144,7 +144,7 @@ Optional<ByteBuffer> Gzip::decompress(const ByteBuffer& data)
if (puff_ret == 1) {
// FIXME: Find a better way of decompressing without needing to try over and over again.
#if DEBUG_GZIP
#if GZIP_DEBUG
dbgln("Gzip::decompress: Output buffer exhausted. Growing.");
#endif
destination.grow(destination.size() * 2);

6
Userland/Libraries/LibDebug/DebugInfo.cpp
View file

@ -62,13 +62,13 @@ void DebugInfo::parse_scopes_impl(const Dwarf::DIE& die)
return;
if (child.get_attribute(Dwarf::Attribute::Inline).has_value()) {
#if DEBUG_SPAM
#if SPAM_DEBUG
dbgln("DWARF inlined functions are not supported");
#endif
return;
}
if (child.get_attribute(Dwarf::Attribute::Ranges).has_value()) {
#if DEBUG_SPAM
#if SPAM_DEBUG
dbgln("DWARF ranges are not supported");
#endif
return;
@ -81,7 +81,7 @@ void DebugInfo::parse_scopes_impl(const Dwarf::DIE& die)
scope.name = name.value().data.as_string;
if (!child.get_attribute(Dwarf::Attribute::LowPc).has_value()) {
#if DEBUG_SPAM
#if SPAM_DEBUG
dbgln("DWARF: Couldn't find attribute LowPc for scope");
#endif
return;

4
Userland/Libraries/LibMarkdown/Text.cpp
View file

@ -242,7 +242,7 @@ Optional<Text> Text::parse(const StringView& str)
current_link_is_actually_img = true;
break;
case '[':
#if DEBUG_MARKDOWN
#if MARKDOWN_DEBUG
if (first_span_in_the_current_link != -1)
dbgln("Dropping the outer link");
#endif
@ -250,7 +250,7 @@ Optional<Text> Text::parse(const StringView& str)
break;
case ']': {
if (first_span_in_the_current_link == -1) {
#if DEBUG_MARKDOWN
#if MARKDOWN_DEBUG
dbgln("Unmatched ]");
#endif
continue;

4
Userland/Libraries/LibWeb/WebContentClient.cpp
View file

@ -64,7 +64,7 @@ void WebContentClient::handle(const Messages::WebContentClient::DidInvalidateCon
void WebContentClient::handle(const Messages::WebContentClient::DidChangeSelection&)
{
#if DEBUG_SPAM
#if SPAM_DEBUG
dbgln("handle: WebContentClient::DidChangeSelection!");
#endif
m_view.notify_server_did_change_selection({});
@ -96,7 +96,7 @@ void WebContentClient::handle(const Messages::WebContentClient::DidHoverLink& me
void WebContentClient::handle(const Messages::WebContentClient::DidUnhoverLink&)
{
#if DEBUG_SPAM
#if SPAM_DEBUG
dbgln("handle: WebContentClient::DidUnhoverLink!");
#endif
m_view.notify_server_did_unhover_link({});