RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:07:36 +00:00
Code Issues Activity Actions

LibJS: Format the era of ISO year 0 as BC

Browse source 
This is a normative change in the ECMA-402 spec. See:
2034315
This commit is contained in:
Timothy Flynn 2023-02-01 21:03:59 +00:00 • committed by Linus Groh
parent f0312de7eb
commit bb4fda3b97
2 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/Intl/DateTimeFormat.cpp
View file

@ -1235,8 +1235,8 @@ ThrowCompletionOr<LocalTime> to_local_time(VM& vm, Crypto::SignedBigInteger cons
return LocalTime { return LocalTime {
// WeekDay(𝔽(floor(tz / 10^6))) // WeekDay(𝔽(floor(tz / 10^6)))
.weekday = week_day(zoned_time), .weekday = week_day(zoned_time),
// Let year be YearFromTime(𝔽(floor(tz / 10^6))). If year < -0𝔽, return "BC", else return "AD". // Let year be YearFromTime(𝔽(floor(tz / 10^6))). If year < 1𝔽, return "BC", else return "AD".
.era = year < 0 ? ::Locale::Era::BC : ::Locale::Era::AD, .era = year < 1 ? ::Locale::Era::BC : ::Locale::Era::AD,
// YearFromTime(𝔽(floor(tz / 10^6))) // YearFromTime(𝔽(floor(tz / 10^6)))
.year = year, .year = year,
// undefined. // undefined.

11
Userland/Libraries/LibJS/Tests/builtins/Intl/DateTimeFormat/DateTimeFormat.prototype.format.js
View file

@ -161,6 +161,17 @@ describe("era", () => {
expect(ar.format(d1)).toBe(d.ar1); expect(ar.format(d1)).toBe(d.ar1);
}); });
}); });
test("Year 1 BC (ISO year 0)", () => {
let year1BC = new Date(Date.UTC(0));
year1BC.setUTCFullYear(0);
const en = new Intl.DateTimeFormat("en", { era: "short", timeZone: "UTC" });
expect(en.format(year1BC)).toBe("1/1/1 BC");
const ar = new Intl.DateTimeFormat("ar", { era: "short", timeZone: "UTC" });
expect(ar.format(year1BC)).toBe("١ ١ ١ ق.م");
});
}); });
describe("year", () => { describe("year", () => {