RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:47:45 +00:00
Code Issues Activity Actions

Solitaire: Don't invoke srand multiple times

Browse source 
This doesn't need to be invoked each time the game wants something
random.
This commit is contained in:
Timothy Flynn 2021-05-05 10:22:28 -04:00 • committed by Andreas Kling
parent a540ec3519
commit bb7b76e505
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Games/Solitaire/Game.cpp
View file

@ -18,6 +18,8 @@ static constexpr int s_timer_interval_ms = 1000 / 60;
Game::Game() Game::Game()
{ {
srand(time(nullptr));
m_stacks[Stock] = CardStack({ 10, 10 }, CardStack::Type::Stock); m_stacks[Stock] = CardStack({ 10, 10 }, CardStack::Type::Stock);
m_stacks[Waste] = CardStack({ 10 + Card::width + 10, 10 }, CardStack::Type::Waste); m_stacks[Waste] = CardStack({ 10 + Card::width + 10, 10 }, CardStack::Type::Waste);
m_stacks[Foundation4] = CardStack({ Game::width - Card::width - 10, 10 }, CardStack::Type::Foundation); m_stacks[Foundation4] = CardStack({ Game::width - Card::width - 10, 10 }, CardStack::Type::Foundation);
@ -60,7 +62,6 @@ void Game::timer_event(Core::TimerEvent&)
void Game::create_new_animation_card() void Game::create_new_animation_card()
{ {
srand(time(nullptr));
auto card = Card::construct(static_cast<Card::Type>(rand() % Card::Type::__Count), rand() % Card::card_count); auto card = Card::construct(static_cast<Card::Type>(rand() % Card::Type::__Count), rand() % Card::card_count);
card->set_position({ rand() % (Game::width - Card::width), rand() % (Game::height / 8) }); card->set_position({ rand() % (Game::width - Card::width), rand() % (Game::height / 8) });
@ -107,7 +108,6 @@ void Game::setup()
m_new_deck.append(Card::construct(Card::Type::Diamonds, i)); m_new_deck.append(Card::construct(Card::Type::Diamonds, i));
} }
srand(time(nullptr));
for (uint8_t i = 0; i < 200; ++i) for (uint8_t i = 0; i < 200; ++i)
m_new_deck.append(m_new_deck.take(rand() % m_new_deck.size())); m_new_deck.append(m_new_deck.take(rand() % m_new_deck.size()));