RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:08:10 +00:00
Code Issues Activity Actions

LibWeb: Pass correct values to would_start_a_number()

Browse source 
This fixes the crash that Luke found using Domato:
```css
. foo {
    mso-border-alt: solid  .-1pt;
}
```

The spec distinguishes between "If the next 3 code points would
start..." and "If the input stream starts with..." but we were treating
them the same way, skipping the first code point in the process.
This commit is contained in:
Sam Atkins 2021-12-24 16:16:55 +00:00 • committed by Andreas Kling
parent 981badb45f
commit bb82ee5530
2 changed files with 3 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibWeb/CSS/Parser/Tokenizer.cpp
View file

@ -881,11 +881,6 @@ Token Tokenizer::consume_a_numeric_token()
return token;
}
bool Tokenizer::would_start_a_number() const
{
return would_start_a_number(peek_triplet());
}
// https://www.w3.org/TR/css-syntax-3/#starts-with-a-number
bool Tokenizer::would_start_a_number(U32Triplet values)
{
@ -1189,7 +1184,7 @@ Token Tokenizer::consume_a_token()
dbgln_if(CSS_TOKENIZER_DEBUG, "is plus sign");
// If the input stream starts with a number, reconsume the current input code point,
// consume a numeric token and return it.
if (would_start_a_number()) {
if (would_start_a_number(start_of_input_stream_triplet())) {
reconsume_current_input_code_point();
return consume_a_numeric_token();
}
@ -1210,7 +1205,7 @@ Token Tokenizer::consume_a_token()
dbgln_if(CSS_TOKENIZER_DEBUG, "is hyphen minus");
// If the input stream starts with a number, reconsume the current input code point,
// consume a numeric token, and return it.
if (would_start_a_number()) {
if (would_start_a_number(start_of_input_stream_triplet())) {
reconsume_current_input_code_point();
return consume_a_numeric_token();
}
@ -1241,7 +1236,7 @@ Token Tokenizer::consume_a_token()
dbgln_if(CSS_TOKENIZER_DEBUG, "is full stop");
// If the input stream starts with a number, reconsume the current input code point,
// consume a numeric token, and return it.
if (would_start_a_number()) {
if (would_start_a_number(start_of_input_stream_triplet())) {
reconsume_current_input_code_point();
return consume_a_numeric_token();
}