RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:57:35 +00:00
Code Issues Activity Actions

TextEditor: Clear leftover whitespace when inserting newlines

Browse source 
Previously when entering a newline, previous indentation would be left,
leaving a line consisting only of whitespace. This fixes that.
This commit is contained in:
euclidianAce 2021-05-15 11:38:53 -05:00 • committed by GitHub
parent 0994d0a33e
commit bbb21194a5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibGUI/TextEditor.cpp
View file

@ -1244,7 +1244,23 @@ void TextEditor::insert_at_cursor_or_replace_selection(const StringView& text)
VERIFY(is_editable());
if (has_selection())
delete_selection();
// Check if adding a newline leaves the previous line as just whitespace.
auto const clear_length = m_cursor.column();
auto const should_clear_last_line = text == "\n"
&& clear_length > 0
&& current_line().leading_spaces() == clear_length;
execute<InsertTextCommand>(text, m_cursor);
if (should_clear_last_line) { // If it does leave just whitespace, clear it.
auto const original_cursor_position = cursor();
TextPosition start(original_cursor_position.line() - 1, 0);
TextPosition end(original_cursor_position.line() - 1, clear_length);
TextRange erased_range(start, end);
execute<RemoveTextCommand>(document().text_in_range(erased_range), erased_range);
set_cursor(original_cursor_position);
}
}
void TextEditor::cut()