RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 20:05:07 +00:00
Code Issues Activity Actions

LibWeb: Only take runnable tasks from the HTML task queue

Browse source 
We were previously willing to execute tasks before they had become
runnable.
This commit is contained in:
Andreas Kling 2021-10-03 15:38:11 +02:00
parent 6283c098ad
commit bbfde63f79
5 changed files with 23 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/HTML/EventLoop/EventLoop.cpp
View file

@ -90,9 +90,8 @@ void EventLoop::process()
// 1. Let taskQueue be one of the event loop's task queues, chosen in an implementation-defined manner, with the constraint that the chosen task queue must contain at least one runnable task. If there is no such task queue, then jump to the microtasks step below.
auto& task_queue = m_task_queue;
if (!task_queue.is_empty()) {
if (auto oldest_task = task_queue.take_first_runnable()) {
// 2. Let oldestTask be the first runnable task in taskQueue, and remove it from taskQueue.
auto oldest_task = task_queue.take_first_runnable();
// 3. Set the event loop's currently running task to oldestTask.
m_currently_running_task = oldest_task.ptr();