RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:38:11 +00:00
Code Issues Activity Actions

LibWeb: Only take runnable tasks from the HTML task queue

Browse source 
We were previously willing to execute tasks before they had become
runnable.
This commit is contained in:
Andreas Kling 2021-10-03 15:38:11 +02:00
parent 6283c098ad
commit bbfde63f79
5 changed files with 23 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/EventLoop/TaskQueue.h
View file

@ -19,20 +19,20 @@ public:
bool is_empty() const { return m_tasks.is_empty(); }
void add(NonnullOwnPtr<HTML::Task>);
OwnPtr<HTML::Task> take_first_runnable() { return m_tasks.dequeue(); }
OwnPtr<HTML::Task> take_first_runnable();
void enqueue(NonnullOwnPtr<HTML::Task> task) { add(move(task)); }
OwnPtr<HTML::Task> dequeue()
{
if (m_tasks.is_empty())
return {};
return m_tasks.dequeue();
return m_tasks.take_first();
}
private:
HTML::EventLoop& m_event_loop;
Queue<NonnullOwnPtr<HTML::Task>> m_tasks;
Vector<NonnullOwnPtr<HTML::Task>> m_tasks;
};
}