RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:17:35 +00:00
Code Issues Activity Actions

FileManager: Use GUI::SeparatorWidget in the properties dialog

Browse source 
This looks a lot better than putting a GUI::Frame in there.
This commit is contained in:
Andreas Kling 2020-12-30 03:53:37 +01:00
parent 5b1a6d7c66
commit bc0658ce27
2 changed files with 3 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Applications/FileManager/PropertiesDialog.cpp
View file

@ -34,6 +34,7 @@
#include <LibGUI/FilePicker.h> #include <LibGUI/FilePicker.h>
#include <LibGUI/LinkLabel.h> #include <LibGUI/LinkLabel.h>
#include <LibGUI/MessageBox.h> #include <LibGUI/MessageBox.h>
#include <LibGUI/SeparatorWidget.h>
#include <LibGUI/TabWidget.h> #include <LibGUI/TabWidget.h>
#include <grp.h> #include <grp.h>
#include <limits.h> #include <limits.h>
@ -84,7 +85,7 @@ PropertiesDialog::PropertiesDialog(const String& path, bool disable_rename, Wind
}; };
set_icon(Gfx::Bitmap::load_from_file("/res/icons/16x16/properties.png")); set_icon(Gfx::Bitmap::load_from_file("/res/icons/16x16/properties.png"));
make_divider(general_tab); general_tab.add<GUI::SeparatorWidget>(Gfx::Orientation::Horizontal);
struct stat st; struct stat st;
if (lstat(path.characters(), &st)) { if (lstat(path.characters(), &st)) {
@ -135,7 +136,7 @@ PropertiesDialog::PropertiesDialog(const String& path, bool disable_rename, Wind
make_property_value_pairs(properties, general_tab); make_property_value_pairs(properties, general_tab);
make_divider(general_tab); general_tab.add<GUI::SeparatorWidget>(Gfx::Orientation::Horizontal);
make_permission_checkboxes(general_tab, { S_IRUSR, S_IWUSR, S_IXUSR }, "Owner:", m_mode); make_permission_checkboxes(general_tab, { S_IRUSR, S_IWUSR, S_IXUSR }, "Owner:", m_mode);
make_permission_checkboxes(general_tab, { S_IRGRP, S_IWGRP, S_IXGRP }, "Group:", m_mode); make_permission_checkboxes(general_tab, { S_IRGRP, S_IWGRP, S_IXGRP }, "Group:", m_mode);
@ -299,9 +300,3 @@ GUI::Button& PropertiesDialog::make_button(String text, GUI::Widget& parent)
button.set_fixed_size(70, 22); button.set_fixed_size(70, 22);
return button; return button;
} }
void PropertiesDialog::make_divider(GUI::Widget& parent)
{
auto& divider = parent.add<GUI::Frame>();
divider.set_fixed_height(2);
}

1
Applications/FileManager/PropertiesDialog.h
View file

@ -77,7 +77,6 @@ private:
} }
GUI::Button& make_button(String, GUI::Widget& parent); GUI::Button& make_button(String, GUI::Widget& parent);
void make_divider(GUI::Widget& parent);
void make_property_value_pairs(const Vector<PropertyValuePair>& pairs, GUI::Widget& parent); void make_property_value_pairs(const Vector<PropertyValuePair>& pairs, GUI::Widget& parent);
void make_permission_checkboxes(GUI::Widget& parent, PermissionMasks, String label_string, mode_t mode); void make_permission_checkboxes(GUI::Widget& parent, PermissionMasks, String label_string, mode_t mode);
void permission_changed(mode_t mask, bool set); void permission_changed(mode_t mask, bool set);