RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:47:37 +00:00
Code Issues Activity Actions

LibJS: Pass in actual_delete_count to removed array creation in splice

Browse source 
More specifically, Array.prototype.splice. Additionally adds a missing
exception check to the array creation and a link to the spec.

Fixes create-non-array-invalid-len.js in the splice tests in test262.
This test timed out instead of throwing an "Invalid array length"
exception.
This commit is contained in:
Luke 2021-06-10 02:09:35 +01:00 • committed by Linus Groh
parent f63ef4f196
commit bc540de0af
2 changed files with 20 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibJS/Tests/builtins/Array/Array.prototype.splice.js
View file

@ -47,3 +47,18 @@ test("basic functionality", () => {
expect(array).toEqual([]);
expect(removed).toEqual(["foo", "bar", "baz"]);
});
// FIXME: These tests are currently skipped because an invalid array length in this case is 2**32 or above.
// The codebase currently uses size_t for lengths, which is currently the same as u32 when building for Serenity.
// This means these lengths wrap around to 0, making the test not work correctly.
test.skip("Invalid lengths", () => {
var length = Math.pow(2, 32);
var obj = {
length: length,
};
expect(() => {
Array.prototype.splice.call(obj, 0);
}).toThrowWithMessage(RangeError, "Invalid array length");
});