RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 00:47:34 +00:00
Code Issues Activity Actions

LibELF: Reject ELF with program header p_filesz larger than p_memsz

Browse source
This commit is contained in:
Brendan Coles 2020-12-27 22:01:56 +00:00 • committed by Andreas Kling
parent ca0f3db004
commit bceee87f61
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibELF/Validation.cpp
View file

@ -193,6 +193,13 @@ bool validate_program_headers(const Elf32_Ehdr& elf_header, size_t file_size, co
for (size_t header_index = 0; header_index < num_program_headers; ++header_index) { for (size_t header_index = 0; header_index < num_program_headers; ++header_index) {
auto& program_header = program_header_begin[header_index]; auto& program_header = program_header_begin[header_index];
if (program_header.p_filesz > program_header.p_memsz) {
if (verbose)
dbgln("Program header ({}) has p_filesz ({}) larger than p_memsz ({})", header_index, program_header.p_filesz, program_header.p_memsz);
return false;
}
switch (program_header.p_type) { switch (program_header.p_type) {
case PT_INTERP: case PT_INTERP:
// We checked above that file_size was >= buffer size. We only care about buffer size anyway, we're trying to read this! // We checked above that file_size was >= buffer size. We only care about buffer size anyway, we're trying to read this!