From bd2fe3dcaa92a03edd5ef8852017962877670939 Mon Sep 17 00:00:00 2001 From: Shannon Booth Date: Sat, 13 Jan 2024 20:12:28 +1300 Subject: [PATCH] LibWeb: Use FlyString in Document::get_elements_by_name --- Userland/Libraries/LibWeb/DOM/Document.cpp | 2 +- Userland/Libraries/LibWeb/DOM/Document.h | 2 +- Userland/Libraries/LibWeb/DOM/Document.idl | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/DOM/Document.cpp b/Userland/Libraries/LibWeb/DOM/Document.cpp index 17e5fe44ed..bcbda66e04 100644 --- a/Userland/Libraries/LibWeb/DOM/Document.cpp +++ b/Userland/Libraries/LibWeb/DOM/Document.cpp @@ -1250,7 +1250,7 @@ void Document::set_hovered_node(Node* node) } } -JS::NonnullGCPtr Document::get_elements_by_name(String const& name) +JS::NonnullGCPtr Document::get_elements_by_name(FlyString const& name) { return HTMLCollection::create(*this, HTMLCollection::Scope::Descendants, [name](Element const& element) { return element.name() == name; diff --git a/Userland/Libraries/LibWeb/DOM/Document.h b/Userland/Libraries/LibWeb/DOM/Document.h index 4db04655e1..4a19cb4c82 100644 --- a/Userland/Libraries/LibWeb/DOM/Document.h +++ b/Userland/Libraries/LibWeb/DOM/Document.h @@ -219,7 +219,7 @@ public: void schedule_style_update(); void schedule_layout_update(); - JS::NonnullGCPtr get_elements_by_name(String const&); + JS::NonnullGCPtr get_elements_by_name(FlyString const&); JS::NonnullGCPtr get_elements_by_class_name(StringView); JS::NonnullGCPtr applets(); diff --git a/Userland/Libraries/LibWeb/DOM/Document.idl b/Userland/Libraries/LibWeb/DOM/Document.idl index 8640fec711..75812cd320 100644 --- a/Userland/Libraries/LibWeb/DOM/Document.idl +++ b/Userland/Libraries/LibWeb/DOM/Document.idl @@ -58,7 +58,7 @@ interface Document : Node { readonly attribute Element? activeElement; Element? getElementById(DOMString id); - HTMLCollection getElementsByName(DOMString name); + HTMLCollection getElementsByName([FlyString] DOMString name); HTMLCollection getElementsByTagName(DOMString tagName); HTMLCollection getElementsByTagNameNS(DOMString? namespace, DOMString localName); HTMLCollection getElementsByClassName(DOMString className);