RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 16:28:11 +00:00
Code Issues Activity Actions

LibCore: Don't double-check select() in Socket's read notifier callback

Browse source 
This was used to work around a possible bug where select() would mark a
socket readable, but another user of the same socket would read before
the notifier's callback is run; let's remove this and fix any issues
regarding that specific situation later when they pop up.
This commit is contained in:
Ali Mohammad Pur 2021-09-19 18:22:38 +04:30 • committed by Ali Mohammad Pur
parent 81a0301d4d
commit bd4f7421cf
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCore/Socket.cpp
View file

@ -213,8 +213,6 @@ void Socket::ensure_read_notifier()
VERIFY(m_connected);
m_read_notifier = Notifier::construct(fd(), Notifier::Event::Read, this);
m_read_notifier->on_ready_to_read = [this] {
if (!can_read())
return;
if (on_ready_to_read)
on_ready_to_read();
};