RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 08:37:46 +00:00
Code Issues Activity Actions

LibJS: Explicitly pass a "Function& new_target" to Function::construct

Browse source 
This allows the proxy handler to pass the proper new.target to construct
handlers.
This commit is contained in:
Matthew Olsson 2020-06-25 15:30:58 -07:00 • committed by Andreas Kling
parent 19411e22d0
commit bda39ef7ab
38 changed files with 63 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.cpp
View file

@ -59,10 +59,10 @@ XMLHttpRequestConstructor::~XMLHttpRequestConstructor()
JS::Value XMLHttpRequestConstructor::call(JS::Interpreter& interpreter)
{
return construct(interpreter);
return construct(interpreter, *this);
}
JS::Value XMLHttpRequestConstructor::construct(JS::Interpreter& interpreter)
JS::Value XMLHttpRequestConstructor::construct(JS::Interpreter& interpreter, Function&)
{
auto& window = static_cast<WindowObject&>(global_object());
return interpreter.heap().allocate<XMLHttpRequestWrapper>(window, window, XMLHttpRequest::create(window.impl()));

2
Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.h
View file

@ -38,7 +38,7 @@ public:
virtual ~XMLHttpRequestConstructor() override;
virtual JS::Value call(JS::Interpreter&) override;
virtual JS::Value construct(JS::Interpreter&) override;
virtual JS::Value construct(JS::Interpreter& interpreter, Function& new_target) override;
private:
virtual bool has_constructor() const override { return true; }