RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 21:27:34 +00:00
Code Issues Activity Actions

nologin: Use proper format strings with out() and outln()

Browse source 
1. Don't use the sv literal as this bypasses CheckedFormatString.

2. Don't use the content of a file as the format string. If the file
   contains "{}", the program will crash.
This commit is contained in:
Timothy Flynn 2022-10-31 09:04:01 -04:00 • committed by Tim Flynn
parent a80da456a5
commit bda737fde7
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Utilities/nologin.cpp
View file

@ -4,6 +4,7 @@
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
#include <AK/StringView.h>
#include <LibCore/Stream.h> #include <LibCore/Stream.h>
#include <LibCore/System.h> #include <LibCore/System.h>
#include <LibMain/Main.h> #include <LibMain/Main.h>
@ -14,10 +15,10 @@ ErrorOr<int> serenity_main(Main::Arguments)
auto file_or_error = Core::Stream::File::open("/etc/nologin"sv, Core::Stream::OpenMode::Read); auto file_or_error = Core::Stream::File::open("/etc/nologin"sv, Core::Stream::OpenMode::Read);
if (file_or_error.is_error()) { if (file_or_error.is_error()) {
outln("This account is currently not available."sv); outln("This account is currently not available.");
} else { } else {
auto message_from_file = TRY(file_or_error.value()->read_all()); auto message_from_file = TRY(file_or_error.value()->read_all());
out(message_from_file); out("{}", StringView { message_from_file });
} }
return 1; return 1;