RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 20:05:07 +00:00
Code Issues Activity Actions

LibWeb: Convert Element "attribute change steps" from vector to virtual

Browse source 
By using a virtual function and overriding it on HTMLSlotElement, we
shrink every DOM element by 24 bytes. :^)
This commit is contained in:
Andreas Kling 2023-11-19 21:28:18 +01:00
parent aa23a7b58d
commit bdac94870c
4 changed files with 68 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

58
Userland/Libraries/LibWeb/HTML/HTMLSlotElement.cpp
View file

@ -17,33 +17,6 @@ JS_DEFINE_ALLOCATOR(HTMLSlotElement);
HTMLSlotElement::HTMLSlotElement(DOM::Document& document, DOM::QualifiedName qualified_name)
: HTMLElement(document, move(qualified_name))
{
// https://dom.spec.whatwg.org/#ref-for-concept-element-attributes-change-ext
add_attribute_change_steps([this](auto const& local_name, auto const& old_value, auto const& value, auto const& namespace_) {
// 1. If element is a slot, localName is name, and namespace is null, then:
if (local_name == AttributeNames::name && !namespace_.has_value()) {
// 1. If value is oldValue, then return.
if (value == old_value)
return;
// 2. If value is null and oldValue is the empty string, then return.
if (!value.has_value() && old_value == String {})
return;
// 3. If value is the empty string and oldValue is null, then return.
if (value == String {} && !old_value.has_value())
return;
// 4. If value is null or the empty string, then set element’s name to the empty string.
if (!value.has_value())
set_slot_name({});
// 5. Otherwise, set element’s name to value.
else
set_slot_name(*value);
// 6. Run assign slottables for a tree with element’s root.
DOM::assign_slottables_for_a_tree(root());
}
});
}
HTMLSlotElement::~HTMLSlotElement() = default;
@ -142,4 +115,35 @@ void HTMLSlotElement::assign(Vector<SlottableHandle> nodes)
assign_slottables_for_a_tree(root());
}
// https://dom.spec.whatwg.org/#ref-for-concept-element-attributes-change-ext
void HTMLSlotElement::attribute_change_steps(FlyString const& local_name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_)
{
Base::attribute_change_steps(local_name, old_value, value, namespace_);
// 1. If element is a slot, localName is name, and namespace is null, then:
if (local_name == AttributeNames::name && !namespace_.has_value()) {
// 1. If value is oldValue, then return.
if (value == old_value)
return;
// 2. If value is null and oldValue is the empty string, then return.
if (!value.has_value() && old_value == String {})
return;
// 3. If value is the empty string and oldValue is null, then return.
if (value == String {} && !old_value.has_value())
return;
// 4. If value is null or the empty string, then set element’s name to the empty string.
if (!value.has_value())
set_slot_name({});
// 5. Otherwise, set element’s name to value.
else
set_slot_name(*value);
// 6. Run assign slottables for a tree with element’s root.
DOM::assign_slottables_for_a_tree(root());
}
}
}