RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:17:35 +00:00
Code Issues Activity Actions

LibJS: Remove almost all uses of Op::Jump::set_targets()

Browse source 
We should initialize jump targets when constructing the jump instruction
instead of doing it later. This was already the case in all construction
sites but one. This first patch converts all those sites to pass final
targets to the constructor directly.
This commit is contained in:
Andreas Kling 2023-09-28 12:43:11 +02:00
parent 84850700a0
commit bdd21cf9db
3 changed files with 67 additions and 98 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibJS/Bytecode/Op.h
View file

@ -816,21 +816,21 @@ class Jump : public Instruction {
public:
constexpr static bool IsTerminator = true;
explicit Jump(Type type, Optional<Label> taken_target = {}, Optional<Label> nontaken_target = {})
explicit Jump(Type type, Label taken_target, Optional<Label> nontaken_target = {})
: Instruction(type, sizeof(*this))
, m_true_target(move(taken_target))
, m_false_target(move(nontaken_target))
{
}
explicit Jump(Optional<Label> taken_target = {}, Optional<Label> nontaken_target = {})
explicit Jump(Label taken_target, Optional<Label> nontaken_target = {})
: Instruction(Type::Jump, sizeof(*this))
, m_true_target(move(taken_target))
, m_false_target(move(nontaken_target))
{
}
void set_targets(Optional<Label> true_target, Optional<Label> false_target)
void set_targets(Label true_target, Optional<Label> false_target)
{
m_true_target = move(true_target);
m_false_target = move(false_target);
@ -849,7 +849,7 @@ protected:
class JumpConditional final : public Jump {
public:
explicit JumpConditional(Optional<Label> true_target = {}, Optional<Label> false_target = {})
explicit JumpConditional(Label true_target, Label false_target)
: Jump(Type::JumpConditional, move(true_target), move(false_target))
{
}
@ -860,7 +860,7 @@ public:
class JumpNullish final : public Jump {
public:
explicit JumpNullish(Optional<Label> true_target = {}, Optional<Label> false_target = {})
explicit JumpNullish(Label true_target, Label false_target)
: Jump(Type::JumpNullish, move(true_target), move(false_target))
{
}
@ -871,7 +871,7 @@ public:
class JumpUndefined final : public Jump {
public:
explicit JumpUndefined(Optional<Label> true_target = {}, Optional<Label> false_target = {})
explicit JumpUndefined(Label true_target, Label false_target)
: Jump(Type::JumpUndefined, move(true_target), move(false_target))
{
}